From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753739AbbBTA17 (ORCPT ); Thu, 19 Feb 2015 19:27:59 -0500 Received: from bes.se.axis.com ([195.60.68.10]:54289 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbbBTA16 (ORCPT ); Thu, 19 Feb 2015 19:27:58 -0500 Date: Fri, 20 Feb 2015 01:27:55 +0100 From: Jesper Nilsson To: Rabin Vincent Cc: Jesper Nilsson , linux-cris-kernel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/6] CRISv32: don't enable irqs in INIT_THREAD Message-ID: <20150220002755.GA11399@axis.com> References: <1424374196-4954-1-git-send-email-rabin@rab.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424374196-4954-1-git-send-email-rabin@rab.in> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 19, 2015 at 08:29:51PM +0100, Rabin Vincent wrote: > INIT_THREAD enables interrupts in the thread_struct's saved flags. This > means that interrupts get enabled in the middle of context_switch() > while switching to new tasks that get forked off the init task during > boot. Don't do this. > > Fixes the following splat on boot with spinlock debugging on: > > BUG: spinlock cpu recursion on CPU#0, swapper/2 > lock: runqueues+0x0/0x47c, .magic: dead4ead, .owner: swapper/0, > .owner_cpu: 0 > CPU: 0 PID: 2 Comm: swapper Not tainted 3.19.0-08796-ga747b55 #285 > > Call Trace: > [] spin_bug+0x2a/0x36 > [] do_raw_spin_lock+0xa2/0x126 > [] _raw_spin_lock+0x20/0x2a > [] scheduler_tick+0x22/0x76 > [] update_process_times+0x5e/0x72 > [] timer_interrupt+0x4e/0x6a > [] handle_irq_event_percpu+0x54/0xf2 > [] handle_irq_event+0x50/0x74 > [] handle_simple_irq+0x6c/0xbe > [] generic_handle_irq+0x2a/0x36 > [] do_IRQ+0x38/0x84 > [] crisv32_do_IRQ+0x54/0x60 > [] IRQ0x4b_interrupt+0x34/0x3c > [] __schedule+0x24a/0x532 > [] ret_from_kernel_thread+0x0/0x14 > > Signed-off-by: Rabin Vincent Looks good, adding to the CRIS-tree. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com