public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
Date: Fri, 20 Feb 2015 10:52:47 +0100	[thread overview]
Message-ID: <201502201052.47515@pali> (raw)
In-Reply-To: <7411731.0J5JRAOyMm@wuerfel>

[-- Attachment #1: Type: Text/Plain, Size: 977 bytes --]

On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote:
> On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> > Offset for smc91x must be zero otherwise smc91x linux kernel
> > driver does not detect smc91x ethernet hardware in qemu
> > N900 machine.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> 
> Is that the same offset on real hardware, or could this be a
> mistake in the qemu model?
> 
> 	Arnd

In original Nokia 2.6.28 kernel is offset also set to 0, see:

https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42

https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274

Tony already tested offset 0 on real HW and wrote that it is
working too, just show some warning. But qemu with offset 0x300
does not work.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2015-02-20  9:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 16:49 [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet Pali Rohár
2015-02-20  9:24 ` Arnd Bergmann
2015-02-20  9:52   ` Pali Rohár [this message]
2015-02-20 15:28     ` Tony Lindgren
2015-02-24 18:02       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201502201052.47515@pali \
    --to=pali.rohar@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox