Re: [RFC PATCH 01/11] x86,fpu: document the data structures a little

Dave Hansen
2015-01-12T21:52:18Z

On 01/11/2015 01:46 PM, riel@redhat.com wrote:
> +/*
> + * The FPU state used depends on the capabilities of the hardware; the
> + * registers used for vector instructions on newer hardware are included
> + * in the FPU state.
> + */
> union thread_xstate {

Tiny nit, if you happen to revise this set at some point...

While you probably don't need/want to have an exhaustive list of
everything that gets saved in there, we should probably still mention
that it's a lot more than just vector instructions.

I'd say:

The FPU state used depends on the capabilities of the
hardware. This state increasingly contains things
not related to the FPU itself, like registers used for
vector instructions.