From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbbBTOjm (ORCPT ); Fri, 20 Feb 2015 09:39:42 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:42853 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbbBTOjk (ORCPT ); Fri, 20 Feb 2015 09:39:40 -0500 Date: Fri, 20 Feb 2015 08:39:06 -0600 From: Felipe Balbi To: Pavel Machek CC: Felipe Balbi , Pali =?iso-8859-1?Q?Roh=E1r?= , Linux USB Mailing List , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150220143906.GA1707@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502032057.11166@pali> <201502051338.59040@pali> <201502200109.48793@pali> <20150220030611.GA19507@saruman.tx.rr.com> <20150220082750.GC14057@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline In-Reply-To: <20150220082750.GC14057@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > In current state I review all 3 patches as: > > > > > > >=20 > > > > > > > Rejected-by: Pali Roh=E1r > > > > > > > [It breaks booting Nokia N900 device] > > > > > >=20 > > > > > > next step, figure why it's broken. Working just fine here > > > > > > on AM335x which has the same musb IP. > > > > >=20 > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > it. > > > >=20 > > > > Actually when I reverted only that patch which adds line: > > > >=20 > > > > pm_runtime_irq_safe(musb->controller) > > > >=20 > > > > then early boot crash disappeared. > > > >=20 > > > > But other two patches did not fixed support for external .ko > > > > gadget modules. State is same -- crash after modprobe. > > >=20 > > > Here is crash from qemu when musb is compiled into kernel: > > >=20 > > > [ 0.641662] Unable to handle kernel NULL pointer dereference at vi= rtual address 00000000 > > > [ 0.642211] pgd =3D c0004000 > ... > > > [ 0.672882] ---[ end Kernel panic - not syncing: Attempted to kill= init! exitcode=3D0x0000000b > > > [ 0.672882] > > >=20 > > > Reason why it crashes is because when function > > > omap2430_runtime_resume() is called pointer to functions=20 > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > dereference. > >=20 > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=3D= testing/next&id=3D1861a2c60351a390272b3395f4d88480cdfd9e58 > > >=20 > So you commit a fix to your internal branch without telling Pali, who > is actively debugging same problem at the same time, and then you just > send him url without at least saying "sorry"? grow up... why do I have to say sorry for fixing a problem ? Why do I have to let you know I committed something to my branch ? It's the middle of the merge window, nothing will happen until -rc1 is out, at which point I'll send this to the mailing list before sending a pull request to Greg. --=20 balbi --G4iJoqBmSsgzjUCe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU50cKAAoJEIaOsuA1yqREEJcP/36pnJvwxsfCME3xKTXA7hv3 I9gZApzJ46Ym4RpkHX5XYfyu/6qaFHwc9VfNnKhG4WK+L3bIDAgh8DRvjxpSt9Q3 rI5WRkzRbORgJeJQHSvUzcaNeeOY8ttQbVxXCyBiN6EB0199AivPWMRQg9BcGTjv 1bWoCmF8jTtr52jbXXt4SGH17srnfUZFGpyDHbSceuLTuB05v6MuRB2ZD4QwTEB7 zfwYSWekAJXfg+RfQ4hhy9Jhkt3yTlsx3HybduoQ7xmJiilGI0gGBs4HIQP62inm iLh4mKoDOJucUiE19oGA7pJ2EDA7d9ASPodBvzg6s+lRT3bhWsqmd1Wvv2DbMpTi 5uS3bzljrv/fXtieKk+1Yu138rVgtyFJYyhjjMhx8wk83drWefNCFUKNINTVyHSJ GNEW2B3xTQfScm04B3BHXugcLyL3tEnLPecVDTfGXucSvqHfLOQVXGrRDqdYi7ve Eoi45MFs6SlSWysVTRL9SDZWOFG9s5pyVQR5RaJDPRB1h9OtV6ZgH4NyUSpnSCwe AYmIfjTwjOBx9ZEKo8xSNeNIpsbK5m4UPofD3D/yR4dgaafRn1akTupdWvditSWQ 9mB7j4fnUGyaGy31+EYledQvRHLK5YMOS06J6JK8yB9yMfvmj+5o6IHjhDVgMM0g VZeAGpRT2lZQHgT+6Nhm =mgm9 -----END PGP SIGNATURE----- --G4iJoqBmSsgzjUCe--