From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>, Mike Galbraith <efault@gmx.de>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH RESEND v9 10/10] sched: move cfs task on a CPU with higher capacity
Date: Fri, 20 Feb 2015 17:26:41 +0100 [thread overview]
Message-ID: <20150220162641.GS5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtCUppWUV_V=P1PCbF-cMjbAyVKoDwqAfdxvZQaHN6X6mw@mail.gmail.com>
On Fri, Feb 20, 2015 at 02:54:09PM +0100, Vincent Guittot wrote:
> >> if (rq->nr_running >= 2)
> >> + return true;
> >
> > So this,
> >> + sd = rcu_dereference(rq->sd);
> >> + if (sd) {
> >> + if ((rq->cfs.h_nr_running >= 1) &&
> >> + check_cpu_capacity(rq, sd)) {
> >> + kick = true;
> >> + goto unlock;
> >> + }
> >> + }
> >
> > vs this: how would we ever get here?
> >
> > If h_nr_running > 1, must then not nr_running > 1 as well?
>
> you're right,
> but the test above can trig a kick with h_nr_running == 1 whereas the
> other tests may not
Duh, clearly I cannot read today.
next prev parent reply other threads:[~2015-02-20 16:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 10:09 [PATCH RESEND v9 00/10] sched: consolidation of CPU capacity and usage Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 01/10] sched: add utilization_avg_contrib Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 02/10] sched: Track group sched_entity usage contributions Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 03/10] sched: remove frequency scaling from cpu_capacity Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 04/10] sched: Make sched entity usage tracking scale-invariant Vincent Guittot
2015-02-19 16:34 ` Peter Zijlstra
2015-02-19 17:02 ` Morten Rasmussen
2015-02-19 17:05 ` Peter Zijlstra
2015-02-20 9:21 ` Morten Rasmussen
2015-01-15 10:09 ` [PATCH RESEND v9 05/10] sched: make scale_rt invariant with frequency Vincent Guittot
2015-02-19 16:52 ` Peter Zijlstra
2015-02-19 17:18 ` Morten Rasmussen
2015-02-24 10:21 ` Vincent Guittot
2015-02-24 11:33 ` Dietmar Eggemann
2015-01-15 10:09 ` [PATCH RESEND v9 06/10] sched: add per rq cpu_capacity_orig Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 07/10] sched: get CPU's usage statistic Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 08/10] sched: replace capacity_factor by usage Vincent Guittot
2015-02-20 11:14 ` Peter Zijlstra
2015-02-20 13:31 ` Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 09/10] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 10/10] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2015-02-20 11:27 ` Peter Zijlstra
2015-02-20 13:54 ` Vincent Guittot
2015-02-20 16:26 ` Peter Zijlstra [this message]
2015-02-19 12:49 ` [PATCH RESEND v9 00/10] sched: consolidation of CPU capacity and usage Morten Rasmussen
2015-02-20 11:34 ` Peter Zijlstra
2015-02-20 11:52 ` Morten Rasmussen
2015-02-20 14:13 ` Vincent Guittot
2015-02-20 14:35 ` Morten Rasmussen
2015-02-20 14:54 ` Vincent Guittot
2015-02-23 15:45 ` Morten Rasmussen
2015-02-24 10:38 ` Vincent Guittot
2015-02-24 11:29 ` Morten Rasmussen
2015-02-24 12:18 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220162641.GS5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox