From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
tglx@linutronix.de, luto@amacapital.net, fruggeri@arista.com,
a.ryabinin@samsung.com, akpm@linux-foundation.org, hpa@zytor.com,
Adrien Schildknecht <adrien+dev@schischi.me>,
linux-kernel@vger.kernel.org, adech.fo@gmail.com, x86@kernel.org,
mingo@redhat.com
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
Date: Fri, 20 Feb 2015 18:35:14 +0100 [thread overview]
Message-ID: <20150220173514.GF19378@pd.tnic> (raw)
In-Reply-To: <20150220120506.1c3812a8@grimm.local.home>
On Fri, Feb 20, 2015 at 12:05:06PM -0500, Steven Rostedt wrote:
> printk: Comment pr_cont() stating it is only to continue a line
>
> KERN_CONT is nicely commented in kern_levels.h, but pr_cont() is now
> used more often, and it lacks the comment stating what it is used for.
> It can be confused as continuing the log level, but that is not its
> purpose. It's purpose is to continue a line that had no newline
> enclosed. This should be documented by pr_cont() as well.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
I sure could've used that info when looking at this yesterday. Good
patch.
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-02-20 17:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 22:43 [PATCH 0/2] x86: fix output of show_stack_log_lvl Adrien Schildknecht
2015-02-19 22:43 ` [PATCH 1/2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 0:06 ` Borislav Petkov
2015-02-19 22:43 ` [PATCH 2/2] x86: fix output of show_trace_log_lvl() Adrien Schildknecht
2015-02-20 2:34 ` [PATCH v2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 4:45 ` Steven Rostedt
[not found] ` <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
2015-02-20 17:05 ` Steven Rostedt
2015-02-20 17:35 ` Borislav Petkov [this message]
2015-02-20 17:40 ` Joe Perches
[not found] ` <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
2015-02-20 18:03 ` Joe Perches
2015-02-20 18:51 ` Linus Torvalds
2015-02-20 19:15 ` Joe Perches
2015-02-20 8:10 ` Ingo Molnar
2015-02-20 10:38 ` Borislav Petkov
2015-02-20 16:39 ` Adrien Schildknecht
2015-03-03 11:28 ` [tip:x86/debug] x86/kernel: Fix " tip-bot for Adrien Schildknecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220173514.GF19378@pd.tnic \
--to=bp@alien8.de \
--cc=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=fruggeri@arista.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox