From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754517AbbBTUhm (ORCPT ); Fri, 20 Feb 2015 15:37:42 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37990 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbbBTUhk (ORCPT ); Fri, 20 Feb 2015 15:37:40 -0500 Date: Fri, 20 Feb 2015 12:37:38 -0800 From: Stephen Boyd To: Will Deacon Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/2] ARM: perf: Preparatory work for Scorpion PMU support Message-ID: <20150220203738.GE24928@codeaurora.org> References: <1423851849-6069-1-git-send-email-sboyd@codeaurora.org> <1423851849-6069-2-git-send-email-sboyd@codeaurora.org> <20150220193034.GD1767@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150220193034.GD1767@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/20, Will Deacon wrote: > On Fri, Feb 13, 2015 at 06:24:08PM +0000, Stephen Boyd wrote: > > Do some things to make the Krait PMU support code generic enough > > to be used by the Scorpion PMU support code. > > > > * Rename the venum register functions to be venum instead of krait > > specific because the same registers exist on Scorpion > > > > * Add a krait_decode_event() function to decode our Krait specific > > event encoding that's the same on Scorpion (modulo an extra region). > > > > * Drop krait from krait_clear_pmresrn_group() so it can be used > > by Scorpion code > > > > Signed-off-by: Stephen Boyd > > --- > > arch/arm/kernel/perf_event_v7.c | 87 ++++++++++++++++++++++------------------- > > 1 file changed, 46 insertions(+), 41 deletions(-) > > [...] > > > +static void krait_decode_event(u32 event, unsigned int *region, > > + unsigned int *group, unsigned int *code, bool *venum, bool *cpu) > > +{ > > + if (region) > > + *region = (event >> 12) & 0xf; > > + if (group) > > + *group = (event >> 0) & 0xf; > > + if (code) > > + *code = (event >> 4) & 0xff; > > + if (venum) > > + *venum = !!(event & VENUM_EVENT); > > + if (cpu) > > + *cpu = !!(event & KRAIT_EVENT); > > +} > > Maybe worth sticking these fields in a struct? Failing that, just using > macros for each one and using them in-line isn't so bad. > Ok let's see how a macro goes. Is there any advantage either way? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project