From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751656AbbBUFtJ (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 Feb 2015 00:49:09 -0500
Received: from mail-we0-f174.google.com ([74.125.82.174]:33873 "EHLO
	mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750746AbbBUFtI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 Feb 2015 00:49:08 -0500
Date: Sat, 21 Feb 2015 06:49:02 +0100
From: Ingo Molnar <mingo@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] time/ntp fix
Message-ID: <20150221054901.GA21071@gmail.com>
References: <20150220134417.GA31153@gmail.com>
 <CA+55aFwhqs0SWEDRFdBGLSsjt2i4upc9PJy67CktsB6mTjEu5g@mail.gmail.com>
 <CALAqxLW0MNjj8aLiMHB+i2=4JwETX=KGmK154wnoz2ENmT6dsg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALAqxLW0MNjj8aLiMHB+i2=4JwETX=KGmK154wnoz2ENmT6dsg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* John Stultz <john.stultz@linaro.org> wrote:

> On Fri, Feb 20, 2015 at 2:26 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Fri, Feb 20, 2015 at 5:44 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> John Stultz (1):
> >>       ntp: Fixup adjtimex freq validation on 32-bit systems
> >
> > This is confusing. 32-bit?
> 
> Right, so the check that was added in a previous commit 
> is really only a concern for 64bit systems, but was 
> applied to both 32 and 64bit systems, which results in 
> breaking 32bit systems.
> 
> Thus the "fix" here is to make the check only apply to 
> 64bit systems.

Yeah, perhaps a better commit title would have been to 
write:

     time/ntp: Fix adjtimex freq validation code build warning on 32-bit systems

To make it clear that the problem fixed is a 32-bit 
warning, and that the fix for that is to only check on 
64-bit systems.

I agreed with your BITS_PER_LONG check when I reviewed your 
patch, people usually do an ugly #ifdef, I think this 
in line check form is nicer.

Thanks,

	Ingo