From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444AbbBUHTM (ORCPT ); Sat, 21 Feb 2015 02:19:12 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:54496 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbBUHTJ (ORCPT ); Sat, 21 Feb 2015 02:19:09 -0500 Date: Sat, 21 Feb 2015 01:18:36 -0600 From: Felipe Balbi To: Felipe Balbi CC: Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , Linux USB Mailing List , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150221071836.GA25106@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502032057.11166@pali> <201502051338.59040@pali> <201502200109.48793@pali> <20150220030611.GA19507@saruman.tx.rr.com> <20150220082750.GC14057@amd> <20150220143906.GA1707@saruman.tx.rr.com> <20150220211552.GB28995@amd> <20150221071400.GB24869@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <20150221071400.GB24869@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 21, 2015 at 01:14:00AM -0600, Felipe Balbi wrote: > Hi, >=20 > On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: > > On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > > > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > >=20 > > > > > > > > > > Rejected-by: Pali Roh=E1r > > > > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > >=20 > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > > > > on AM335x which has the same musb IP. > > > > > > > >=20 > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > > > > it. > > > > > > >=20 > > > > > > > Actually when I reverted only that patch which adds line: > > > > > > >=20 > > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > >=20 > > > > > > > then early boot crash disappeared. > > > > > > >=20 > > > > > > > But other two patches did not fixed support for external .ko > > > > > > > gadget modules. State is same -- crash after modprobe. > > > > > >=20 > > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > > >=20 > > > > > > [ 0.641662] Unable to handle kernel NULL pointer dereference= at virtual address 00000000 > > > > > > [ 0.642211] pgd =3D c0004000 > > > > ... > > > > > > [ 0.672882] ---[ end Kernel panic - not syncing: Attempted t= o kill init! exitcode=3D0x0000000b > > > > > > [ 0.672882] > > > > > >=20 > > > > > > Reason why it crashes is because when function > > > > > > omap2430_runtime_resume() is called pointer to functions=20 > > > > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > > > > dereference. > > > > >=20 > > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit= /?h=3Dtesting/next&id=3D1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > > > > > >=20 > > > > So you commit a fix to your internal branch without telling Pali, w= ho > > > > is actively debugging same problem at the same time, and then you j= ust > > > > send him url without at least saying "sorry"? > > >=20 > > > grow up... why do I have to say sorry for fixing a problem ? Why do I > > > have to let you know I committed something to my branch ? It's the > >=20 > > Because that's polite thing to do when you break someone elses system? >=20 > when did I break anything from you ? I sent you a patch to test which > you tested and reported it didn't work and the patch was removed from my > queue because of that. After that you completely refused to do any > work/debug related to an itch only *you* had to start with. >=20 > Seen as you just don't care to help yourself, why should I ? >=20 > You're 100% capable of debugging the problems you reported which I ended > up debugging even without having any HW which reproduced the failured. >=20 > Not to mention that since the beginning *you* have been the unpolite > one, completely reluctant to test anything or find logs because, > aparently, that's a waste of your o-so-valuable time. >=20 > So no, you DO NOT deserve any politeness. When you change your attitude > and start scratching your own itches, then we can talk about politeness; > until then, get used to a similarly aggressive attitude towards you. not to mention that you (actually Pali) even reported the crash on a completely unrelated patch. That phonet patch is still correct, and could have been merged during v3.20 merge window. --=20 balbi --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU6DFMAAoJEIaOsuA1yqREQNoQAJbnzFxtR7bEEmzoxDzUb8W1 VhziXb+R6yVCBEv8Sk6m6i95HRDX1T7GGHJ5LGx5h0In7qETbOOf3jdjYzArb5tF urlzxEPgfRHz6L3Vbee3PEu8r+NMtEAAfMddtawMvKpHRFs5RqijbgQ4WcgAi95/ TZUy7utdlWM7JLfaI/EUv1cJIeYmXukk1PIMcLp1H/PvtwxeyH6YeTVLnJgYfHos Ec4kbsEXlKuo5ev2wYSI1VE1aTiGR4T4f2rb22FNOUNApF6ReqNHGQHNC15flgYL SprpUC20LdI6sqEFHNqynfqjI161rUBGMRAqXAiOs/oJFvCWmCFrmyRMVc1AOBch tcROAoZ0aU9dOOVzNRuUMJhMw+mwb2+4HAUQ1es1YDZII1Uf98Q7h96AyaFlXczN WkEfifVC5GXm1UIcwiyvi52V3/YQ84Z1vwo4X/72Aa5TqSjI7KFszP6wSJd2DZFL oirdcapzaNxYAjEtVRSnmSuUDfUzTNZPMMwvagLpMi+njw8YGABV74zKx1lJbxfi kd7HGu1p+TP5SWz5N5FZJLyUflK/FSfzmLuEO4SJBOwJMFhbrTaUTSNTn3i7WAbN 9P4FMD7TtkBQXWaPyD/8QCDk/+xrpea1JiLZ08y7z/z+JZyPaXXZTm6z7B9bUGsm H6ad5SODMEfhms/zO4ym =laQn -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--