From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbbBVCMA (ORCPT ); Sat, 21 Feb 2015 21:12:00 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:36201 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbbBVCL6 (ORCPT ); Sat, 21 Feb 2015 21:11:58 -0500 Date: Sun, 22 Feb 2015 02:11:57 +0000 From: Al Viro To: Linus Torvalds Cc: Linux Kernel Mailing List , linux-fsdevel Subject: Re: [git pull] more vfs bits Message-ID: <20150222021156.GB29656@ZenIV.linux.org.uk> References: <20150221033452.GU29656@ZenIV.linux.org.uk> <20150222005125.GX29656@ZenIV.linux.org.uk> <20150222020207.GA29656@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150222020207.GA29656@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 22, 2015 at 02:02:07AM +0000, Al Viro wrote: > Hmm... ..._once() variants are trivially dropped, IMO. dentry_inode_once() > is so bloody special that it *SHOULD* stick out; we don't have any places > like that, anyway. > > I'm somewhat tempted to do this: > fs_inode -> d_inode > fs_inode_once ->d_inode_rcu (it's not quite ->d_revalidate()-only, there's > a bit in autofs ->d_manage() as well) > dentry_inode -> something. d_opened_inode() might do, but I'm not sure - > still sounds a bit wrong to me. What it's about is "the actual fs object > behind this name, maybe from upper fs, maybe showing through from underlying > layer". It's not always opened; it's what we'd get if we opened it (and > hadn't triggered any copyups, that is). E.g. sys_getxattr() would want to > use that, even if nobody has opened that sucker yet, etc. *snort* d_inode/d_inode_rcu/[d_]inode_here(), perhaps? ;-)