public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Steven Honeyman <stevenhoneyman@gmail.com>,
	Jean Delvare <jdelvare@suse.de>,
	Valdis.Kletnieks@vt.edu,
	Jochen Eisinger <jochen@penguin-breeder.org>,
	Gabriele Mazzotta <gabriele.mzt@gmail.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: i8k: move driver from char to hwmon
Date: Sun, 22 Feb 2015 12:50:49 +0100	[thread overview]
Message-ID: <201502221250.49466@pali> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 1446 bytes --]

Hello,

currently i8k driver for DELLDIAG SMM operations (charger, 
battery, hotkeys, temperature and fan control) supports two 
interfaces:

1) old /proc/i8k char device
2) new hwmon interface

Driver now lives in char subsystem, but nowadays I think lot of 
people are interested only in hwmon interface which provides 
temperature & fan control. Power management and hotkeys support 
(which is missing in 2) but provided by 1)) is already handled by 
ACPI or input subsystem for new laptops.

Also name "i8k" is really non intuitive what it means and 
supports... (I was told it is abbreviation for Inspirion 8000 
model which was probably first dell model supported by that 
DELLDIAG interface). Now driver is used on Vostro, Latitude and 
also Precision and XPS models. I think at least "dell" should be 
part of driver name and config option.

So I have idea for some changes:

1) Move driver from char subsystem to hwmon

2) Rename driver from i8k to something like delldiag or dellsmm

3) Add new CONFIG_ option to enable/disable /proc/i8k device and 
compile only hwmon interface support

What do you think about it?

I do not want to delete /proc/i8k interface (or break support for 
it) as there are still userspace applications which use this old 
interface and for old models it is probably only way how to 
detect power supply and multimedia hotkeys...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2015-02-22 11:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 11:50 Pali Rohár [this message]
2015-02-22 17:33 ` i8k: move driver from char to hwmon Guenter Roeck
2015-02-22 17:44   ` Pali Rohár
2015-02-22 17:55     ` Guenter Roeck
2015-02-22 18:11     ` Guenter Roeck
2015-02-22 22:07       ` Jean Delvare
2015-02-22 23:31         ` Guenter Roeck
2015-04-22  8:23       ` Jean Delvare
2015-04-22  8:42         ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201502221250.49466@pali \
    --to=pali.rohar@gmail.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=arnd@arndb.de \
    --cc=gabriele.mzt@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdelvare@suse.de \
    --cc=jochen@penguin-breeder.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=stevenhoneyman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox