From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbbBWLyJ (ORCPT ); Mon, 23 Feb 2015 06:54:09 -0500 Received: from mail.kernel.org ([198.145.29.136]:43132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbbBWLyF (ORCPT ); Mon, 23 Feb 2015 06:54:05 -0500 Date: Mon, 23 Feb 2015 11:53:56 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Stephen Boyd , Mike Turquette , Bryan Huntsman , Lorenzo Pieralisi , Ralf Baechle , Sylwester Nawrocki , Russell King - ARM Linux , Tomeu Vizoso Subject: Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev() Message-ID: <20150223115356.GA21609@x1> References: <1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com> <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Feb 2015, Andy Shevchenko wrote: > Since clk_register_clkdev() is exported for modules the caller should get a > pointer to the allocated resources. Otherwise the memory leak is guaranteed on > the ->remove() stage. > > Cc: Tomeu Vizoso > Reviewed-by: Mika Westerberg > Signed-off-by: Andy Shevchenko > --- > arch/arm/mach-msm/clock-pcom.c | 9 +++++---- > arch/arm/mach-vexpress/spc.c | 5 ++++- > arch/mips/ath79/clock.c | 6 +++--- > drivers/clk/clk-bcm2835.c | 12 +++++++----- > drivers/clk/clk-max-gen.c | 9 ++++----- > drivers/clk/clk-xgene.c | 6 +++--- > drivers/clk/clkdev.c | 15 ++++++++++----- > drivers/clk/samsung/clk-pll.c | 13 ++++++++----- > drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++--------- > drivers/clk/samsung/clk.c | 35 +++++++++++++++++++--------------- > include/linux/clkdev.h | 2 +- > 11 files changed, 75 insertions(+), 56 deletions(-) What's tying all of these changes together? It would be better (simpler for you) if you split them up by subsystem and resubmitted.