From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 3/3] firmware: dmi_scan: use direct access to static vars
Date: Mon, 23 Feb 2015 13:55:23 +0000 [thread overview]
Message-ID: <20150223135523.GD19367@codeblueprint.co.uk> (raw)
In-Reply-To: <1424259201-24886-4-git-send-email-ivan.khoronzhuk@linaro.org>
On Wed, 18 Feb, at 01:33:21PM, Ivan Khoronzhuk wrote:
> There is no reason to pass static vars to function that can use
> only them.
>
> The dmi_table() can use only dmi_len and dmi_num static vars, so use
> them directly. In this case we can freely change their type in one
> place and slightly decrease redundancy.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> drivers/firmware/dmi_scan.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Applied to the EFI 'next' branch, thanks Ivan.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-02-23 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 11:33 [Patch v2 0/3] firmware: dmi_scan: add some SMBIOSv3 corrections Ivan Khoronzhuk
2015-02-18 11:33 ` [Patch v2 1/3] firmware: dmi_scan: fix dmi_len type Ivan Khoronzhuk
2015-02-23 13:42 ` Matt Fleming
2015-02-18 11:33 ` [Patch v2 2/3] firmware: dmi_scan: use full dmi version for SMBIOS3 Ivan Khoronzhuk
2015-02-23 13:54 ` Matt Fleming
2015-04-13 16:58 ` Jean Delvare
2015-02-18 11:33 ` [Patch v2 3/3] firmware: dmi_scan: use direct access to static vars Ivan Khoronzhuk
2015-02-23 13:55 ` Matt Fleming [this message]
2015-04-13 17:26 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223135523.GD19367@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox