From: Peter Zijlstra <peterz@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able
Date: Mon, 23 Feb 2015 18:09:02 +0100 [thread overview]
Message-ID: <20150223170902.GD5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <54EB5A1F.70306@gmail.com>
On Mon, Feb 23, 2015 at 09:49:35AM -0700, David Ahern wrote:
> Hi Peter:
>
> On 2/18/15 10:45 AM, David Ahern wrote:
> >perf_pmu_disable is called before pmu->add and perf_pmu_enable is called
> >afterwards. No need to call these inside of x86_pmu_add as well.
>
> Does this make sense or did I miss something about the pmu_enable/disable
> functions?
No, I think you're right. Applied, thanks!
next prev parent reply other threads:[~2015-02-23 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:45 [PATCH] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able David Ahern
2015-02-23 16:49 ` David Ahern
2015-02-23 17:09 ` Peter Zijlstra [this message]
2015-03-27 11:46 ` [tip:perf/core] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able() tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223170902.GD5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox