From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752792AbbBWRJJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 12:09:09 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:45187 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752149AbbBWRJI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 12:09:08 -0500
Date: Mon, 23 Feb 2015 18:09:02 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able
Message-ID: <20150223170902.GD5029@twins.programming.kicks-ass.net>
References: <1424281543-67335-1-git-send-email-dsahern@gmail.com>
 <54EB5A1F.70306@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54EB5A1F.70306@gmail.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 23, 2015 at 09:49:35AM -0700, David Ahern wrote:
> Hi Peter:
> 
> On 2/18/15 10:45 AM, David Ahern wrote:
> >perf_pmu_disable is called before pmu->add and perf_pmu_enable is called
> >afterwards. No need to call these inside of x86_pmu_add as well.
> 
> Does this make sense or did I miss something about the pmu_enable/disable
> functions?

No, I think you're right. Applied, thanks!