[PATCH] x86_64: use kstack_end() in dumpstack_64.c

[PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Adrien Schildknecht]

i386 is already using kstack_end() in dumpstack_32.c.
We should also use it to make the code clearer and unify the stack
printing logic some more.

This patch depends on patch "x86: fix output of show_stack_log_lvl()"

Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
---
 arch/x86/kernel/dumpstack_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
index 553573b..5f1c626 100644
--- a/arch/x86/kernel/dumpstack_64.c
+++ b/arch/x86/kernel/dumpstack_64.c
@@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
 				pr_cont(" <EOI> ");
 			}
 		} else {
-		if (((long) stack & (THREAD_SIZE-1)) == 0)
+		if (kstack_end(stack))
 			break;
 		}
 		if ((i % STACKSLOTS_PER_LINE) == 0) {
-- 
2.2.1

Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Steven Rostedt]

On Sun, 22 Feb 2015 16:23:58 +0100
Adrien Schildknecht <adrien+dev@schischi.me> wrote:

> i386 is already using kstack_end() in dumpstack_32.c.
> We should also use it to make the code clearer and unify the stack
> printing logic some more.

Looks fine to me.

> 
> This patch depends on patch "x86: fix output of show_stack_log_lvl()"

I'm curious to what the dependency is? What would break if we apply
this without that patch?

-- Steve

> 
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
> ---
>  arch/x86/kernel/dumpstack_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
> index 553573b..5f1c626 100644
> --- a/arch/x86/kernel/dumpstack_64.c
> +++ b/arch/x86/kernel/dumpstack_64.c
> @@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
>  				pr_cont(" <EOI> ");
>  			}
>  		} else {
> -		if (((long) stack & (THREAD_SIZE-1)) == 0)
> +		if (kstack_end(stack))
>  			break;
>  		}
>  		if ((i % STACKSLOTS_PER_LINE) == 0) {

Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Borislav Petkov]

On Mon, Feb 23, 2015 at 12:17:51PM -0500, Steven Rostedt wrote:
> I'm curious to what the dependency is? What would break if we apply
> this without that patch?

Nah, no dependency - it causes just a little fuzz when the previous one
is missing.

I'll apply it to the proper tree and fixup the commit message :)

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Adrien Schildknecht]

> > This patch depends on patch "x86: fix output of
> > show_stack_log_lvl()"
> 
> I'm curious to what the dependency is? What would break if we apply
> this without that patch?

Maybe I misunderstood "dependency".
I mean that this patch won't apply properly since a line of the context
was changed by the previous patch.
"if ((i % STACKSLOTS_PER_LINE) == 0) {"

-- 
Adrien Schildknecht

Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Steven Rostedt]

On Mon, 23 Feb 2015 18:29:05 +0100
Adrien Schildknecht <adrien+dev@schischi.me> wrote:

> > > This patch depends on patch "x86: fix output of
> > > show_stack_log_lvl()"
> > 
> > I'm curious to what the dependency is? What would break if we apply
> > this without that patch?
> 
> Maybe I misunderstood "dependency".
> I mean that this patch won't apply properly since a line of the context
> was changed by the previous patch.
> "if ((i % STACKSLOTS_PER_LINE) == 0) {"
> 

Yeah, "dependency" is a bit ambiguous here. It can mean both "this
patch wont work without said patch" as well as "this patch wont apply
without said patch". Probably would have been better to say that it
won't apply to avoid the ambiguity.

Also, these types of notes are best stated after the '---' line. As
it's good information for the maintainer pulling in the patch, but
should not go in the change log. Same for comments like "Changes since
version 1 of this series".

That is:

i386 is already using kstack_end() in dumpstack_32.c.
We should also use it to make the code clearer and unify the stack
printing logic some more.

Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
---
Note: This patch depends on patch "x86: fix output of show_stack_log_lvl()"
or it might not apply properly.

 arch/x86/kernel/dumpstack_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


The change log for the above stops at the '---'.

-- Steve

Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

[Borislav Petkov]

On Sun, Feb 22, 2015 at 04:23:58PM +0100, Adrien Schildknecht wrote:
> i386 is already using kstack_end() in dumpstack_32.c.
> We should also use it to make the code clearer and unify the stack
> printing logic some more.
> 
> This patch depends on patch "x86: fix output of show_stack_log_lvl()"
> 
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

[tip:x86/debug] x86/kernel: Use kstack_end() in dumpstack_64.c

[tip-bot for Adrien Schildknecht]

Commit-ID:  04769ae3ac72f86324a189b69f53bf3bfb61acfd
Gitweb:     http://git.kernel.org/tip/04769ae3ac72f86324a189b69f53bf3bfb61acfd
Author:     Adrien Schildknecht <adrien+dev@schischi.me>
AuthorDate: Sun, 22 Feb 2015 16:23:58 +0100
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Mon, 23 Feb 2015 18:37:13 +0100

x86/kernel: Use kstack_end() in dumpstack_64.c

i386 is already using kstack_end() in dumpstack_32.c. We should also
use it to make the code clearer and unify the stack printing logic some
more.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: c: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1424618638-6375-1-git-send-email-adrien+dev@schischi.me
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 arch/x86/kernel/dumpstack_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
index 553573b..5f1c626 100644
--- a/arch/x86/kernel/dumpstack_64.c
+++ b/arch/x86/kernel/dumpstack_64.c
@@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
 				pr_cont(" <EOI> ");
 			}
 		} else {
-		if (((long) stack & (THREAD_SIZE-1)) == 0)
+		if (kstack_end(stack))
 			break;
 		}
 		if ((i % STACKSLOTS_PER_LINE) == 0) {