From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbbBXAxJ (ORCPT ); Mon, 23 Feb 2015 19:53:09 -0500 Received: from pmta1.delivery3.ore.mailhop.org ([54.191.214.36]:57101 "EHLO pmta1.delivery3.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbbBXAxH (ORCPT ); Mon, 23 Feb 2015 19:53:07 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19Bf6lZLSwER0h0522maFPf Date: Mon, 23 Feb 2015 16:40:07 -0800 From: Tony Lindgren To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net, tglx@linutronix.de Subject: Re: [PATCH 18/35] ARM: OMAP: Use explicit broadcast control function Message-ID: <20150224004007.GM32521@atomide.com> References: <20150216121435.203983131@infradead.org> <20150216122413.047305874@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150216122413.047305874@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra [150216 05:13]: > From: Thomas Gleixner > > Replace the clockevents_notify() call with an explicit function call. > > Signed-off-by: Thomas Gleixner > Cc: Tony Lindgren This too seems to work just fine: Tested-by: Tony Lindgren > --- > arch/arm/mach-omap2/cpuidle44xx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > Index: linux/arch/arm/mach-omap2/cpuidle44xx.c > =================================================================== > --- linux.orig/arch/arm/mach-omap2/cpuidle44xx.c > +++ linux/arch/arm/mach-omap2/cpuidle44xx.c > @@ -14,7 +14,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include > @@ -184,8 +184,7 @@ fail: > */ > static void omap_setup_broadcast_timer(void *arg) > { > - int cpu = smp_processor_id(); > - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ON, &cpu); > + tick_broadcast_enable(); > } > > static struct cpuidle_driver omap4_idle_driver = { > >