From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbBXOyO (ORCPT ); Tue, 24 Feb 2015 09:54:14 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:37079 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbbBXOyN (ORCPT ); Tue, 24 Feb 2015 09:54:13 -0500 Date: Tue, 24 Feb 2015 15:54:07 +0100 From: Ingo Molnar To: viresh kumar Cc: Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Linaro Kernel Mailman List , Kevin Hilman , Preeti U Murthy , Daniel Lezcano , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Frederic Weisbecker , Linaro Networking , Steven Miao , Mark Salter , Michal Simek , Ralf Baechle , Ley Foon Tan , Jonas Bonn , "David S. Miller" , Jeff Dike , Guan Xuetao Subject: Re: [PATCH] clockevents: Add (missing) default case for switch blocks Message-ID: <20150224145407.GA26609@gmail.com> References: <20150220093659.GA23469@gmail.com> <20150220113753.GP5029@twins.programming.kicks-ass.net> <20150220114136.GA27483@gmail.com> <20150220132220.GB28882@gmail.com> <20150220140432.GA31928@gmail.com> <20150223163706.GA12551@gmail.com> <54EC5C69.2010909@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54EC5C69.2010909@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * viresh kumar wrote: > On Monday 23 February 2015 10:07 PM, Ingo Molnar wrote:> > > * Viresh Kumar wrote: > > > Ok, could we rename it to something like DETACHED? > > > > 'UNUSED' really gives me the wrong impression - it's what > > we do for unused fields, unused ABI enumertion constants, > > etc. > > Sure. > > >>> Also, I'd suggest to rename all 'modes' to true state > >>> machine naming: STATE_INITIALIZED, STATE_SHUT_DOWN, > >>> STATE_PERIODIC, STATE_RESUMED, etc.: if these are enums > >>> for > >> > >> I thought so initially and it looked like the diff will > >> be huge as all the variables for the enum, i.e. 'mode', > >> need to be renamed to 'state'.. > >> > >> But, if you are okay with it then I would be happy to do > >> that.. > > > > Well, how does the diffstat look like? > > > > But if the conversion was scripted (i.e. is relatively > > secure from typos) then that's still fine IMO. Peter? > > Here is the diff: And here's the diffstat: arch/arm/common/bL_switcher.c | 8 +-- include/linux/clockchips.h | 48 ++++++++++++------ kernel/time/clockevents.c | 109 ++++++++++++++++++++++++------------------ kernel/time/tick-broadcast.c | 22 ++++---- kernel/time/tick-common.c | 9 +-- kernel/time/tick-internal.h | 1 kernel/time/tick-oneshot.c | 6 +- kernel/time/timer_list.c | 16 +++--- 8 files changed, 129 insertions(+), 90 deletions(-) Not too bad I think. Thanks, Ingo