Re: [PATCH RFT v2] x86: move cacheinfo sysfs to generic cacheinfo infrastructure

Sudeep Holla
2015-02-24T18:09:09Z

Hi Boris,

On 24/02/15 17:57, Borislav Petkov wrote:
> On Mon, Feb 23, 2015 at 06:14:25PM +0000, Sudeep Holla wrote:
>> - Rebased on v4.0-rc1
>> - Fixed lockdep warning reported by Borislav
>
> You probably have fixed the lockdep splat but not the NULL pointer
> dereference which was there in the first mail I sent you. I'd suggest
> you find an AMD box with an L3 and do some testing yourself before
> sending out another version.
>

Sorry for the trouble and thanks for giving it a try. OK I will try to
find one, but it may be difficult to grab one.

> Also, when testing, do a snapshot of the sysfs cache hierarchy by doing:
>
> grep . -EriIn /sys/devices/system/cpu/cpu?/cache/*
>

Yes I have checked it on x86.

> before your changes and after and check for differences.
>

And they are exactly same.

> We can't allow ourselves any differences because this is an API.
>

As I mentioned to Ingo in the other email, that shouldn't happen as
generic code is almost based on existing x86 implementation. It was
moved to avoid further duplication while adding support to arm/arm64
and also to consolidate multiple existing duplicate implementations
(x86, ia64, s390 and ppc)

Regards,
Sudeep