From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbbBXSMw (ORCPT ); Tue, 24 Feb 2015 13:12:52 -0500 Received: from pmta2.delivery7.ore.mailhop.org ([54.149.205.143]:33728 "EHLO pmta2.delivery7.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbbBXSL4 (ORCPT ); Tue, 24 Feb 2015 13:11:56 -0500 X-Greylist: delayed 1803 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Feb 2015 13:11:55 EST X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19hX4wLbV4Lc/sxnmMMXQMi Date: Tue, 24 Feb 2015 10:02:28 -0800 From: Tony Lindgren To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Arnd Bergmann , =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet Message-ID: <20150224180228.GC11056@atomide.com> References: <1424364590-14603-1-git-send-email-pali.rohar@gmail.com> <7411731.0J5JRAOyMm@wuerfel> <201502201052.47515@pali> <20150220152856.GH32521@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150220152856.GH32521@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [150220 07:47]: > * Pali Rohár [150220 01:56]: > > On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote: > > > On Thursday 19 February 2015 17:49:50 Pali Rohár wrote: > > > > Offset for smc91x must be zero otherwise smc91x linux kernel > > > > driver does not detect smc91x ethernet hardware in qemu > > > > N900 machine. > > > > > > > > Signed-off-by: Pali Rohár > > > > > > Is that the same offset on real hardware, or could this be a > > > mistake in the qemu model? > > > > > > Arnd > > > > In original Nokia 2.6.28 kernel is offset also set to 0, see: > > > > https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42 > > > > https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274 > > > > Tony already tested offset 0 on real HW and wrote that it is > > working too, just show some warning. But qemu with offset 0x300 > > does not work. > > Yes it works with offset 0, except the smc91x warns about not > using the default offset 0x300 based on the EEPROM. As only > three address lines seem to be connected, we can use offset > 0 just fine, and update the EEPROM configuration as needed. Applying into omap-for-v4.0/fixes with updated comments. Regards, Tony