From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: hans.verkuil@cisco.com, prabhakar.csengg@gmail.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug
Date: Tue, 24 Feb 2015 19:03:46 -0300 [thread overview]
Message-ID: <20150224190346.4cf0b439@recife.lan> (raw)
In-Reply-To: <1424804014-7743-1-git-send-email-shuahkh@osg.samsung.com>
Em Tue, 24 Feb 2015 11:53:34 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> Replace printk KERN_DEBUG with pr_debug in dprintk macro
> defined in au0828.h
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/usb/au0828/au0828.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
> index eb15187..e3e90ea 100644
> --- a/drivers/media/usb/au0828/au0828.h
> +++ b/drivers/media/usb/au0828/au0828.h
> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>
> #define dprintk(level, fmt, arg...)\
> do { if (au0828_debug & level)\
> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
> + pr_debug(pr_fmt(fmt), ## arg);\
NACK.
This is the worse of two words, as it would require both to enable
each debug line via dynamic printk setting and to enable au0828_debug.
Regards,
Mauro
> } while (0)
>
> /* au0828-input.c */
next prev parent reply other threads:[~2015-02-24 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:53 [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug Shuah Khan
2015-02-24 22:03 ` Mauro Carvalho Chehab [this message]
2015-02-24 23:41 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224190346.4cf0b439@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox