* [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug
@ 2015-02-24 18:53 Shuah Khan
2015-02-24 22:03 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2015-02-24 18:53 UTC (permalink / raw)
To: mchehab, hans.verkuil, prabhakar.csengg
Cc: Shuah Khan, linux-media, linux-kernel
Replace printk KERN_DEBUG with pr_debug in dprintk macro
defined in au0828.h
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/usb/au0828/au0828.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
index eb15187..e3e90ea 100644
--- a/drivers/media/usb/au0828/au0828.h
+++ b/drivers/media/usb/au0828/au0828.h
@@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
#define dprintk(level, fmt, arg...)\
do { if (au0828_debug & level)\
- printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
+ pr_debug(pr_fmt(fmt), ## arg);\
} while (0)
/* au0828-input.c */
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug
2015-02-24 18:53 [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug Shuah Khan
@ 2015-02-24 22:03 ` Mauro Carvalho Chehab
2015-02-24 23:41 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2015-02-24 22:03 UTC (permalink / raw)
To: Shuah Khan; +Cc: hans.verkuil, prabhakar.csengg, linux-media, linux-kernel
Em Tue, 24 Feb 2015 11:53:34 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> Replace printk KERN_DEBUG with pr_debug in dprintk macro
> defined in au0828.h
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/usb/au0828/au0828.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
> index eb15187..e3e90ea 100644
> --- a/drivers/media/usb/au0828/au0828.h
> +++ b/drivers/media/usb/au0828/au0828.h
> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>
> #define dprintk(level, fmt, arg...)\
> do { if (au0828_debug & level)\
> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
> + pr_debug(pr_fmt(fmt), ## arg);\
NACK.
This is the worse of two words, as it would require both to enable
each debug line via dynamic printk setting and to enable au0828_debug.
Regards,
Mauro
> } while (0)
>
> /* au0828-input.c */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug
2015-02-24 22:03 ` Mauro Carvalho Chehab
@ 2015-02-24 23:41 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2015-02-24 23:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: hans.verkuil, prabhakar.csengg, linux-media, linux-kernel
On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Feb 2015 11:53:34 -0700
> Shuah Khan <shuahkh@osg.samsung.com> escreveu:
>
>> Replace printk KERN_DEBUG with pr_debug in dprintk macro
>> defined in au0828.h
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> drivers/media/usb/au0828/au0828.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
>> index eb15187..e3e90ea 100644
>> --- a/drivers/media/usb/au0828/au0828.h
>> +++ b/drivers/media/usb/au0828/au0828.h
>> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>>
>> #define dprintk(level, fmt, arg...)\
>> do { if (au0828_debug & level)\
>> - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
>> + pr_debug(pr_fmt(fmt), ## arg);\
>
> NACK.
>
> This is the worse of two words, as it would require both to enable
> each debug line via dynamic printk setting and to enable au0828_debug.
>
> Regards,
> Mauro
Ah. I missed that. Sorry for the noise.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-24 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-24 18:53 [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug Shuah Khan
2015-02-24 22:03 ` Mauro Carvalho Chehab
2015-02-24 23:41 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox