* [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
@ 2015-02-24 21:00 Ameen Ali
2015-02-24 22:10 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Ameen Ali @ 2015-02-24 21:00 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ameen Ali
else if at line 406 has the same condition as the else if at line 404.
Signed-off-by : Ameen Ali <Ameenali023@gmail.com>
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index 3c651d5..944cf7b 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
pRaInfo->PTModeSS = 3;
else if (pRaInfo->HighestRate > 0x0b)
pRaInfo->PTModeSS = 2;
- else if (pRaInfo->HighestRate > 0x0b)
+ else if (pRaInfo->HighestRate > 0x5)
pRaInfo->PTModeSS = 1;
else
pRaInfo->PTModeSS = 0;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
2015-02-24 21:00 [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404 Ameen Ali
@ 2015-02-24 22:10 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-02-24 22:10 UTC (permalink / raw)
To: Ameen Ali; +Cc: gregkh, devel, linux-kernel
On Tue, Feb 24, 2015 at 11:00:31PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
>
The changelog should really say why you think 0x5 is correct. Could you
update and resend?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
@ 2015-02-25 16:34 Ameen Ali
2015-03-20 12:48 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ameen Ali @ 2015-02-25 16:34 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ameen Ali
else if at line 406 has the same condition as the else if at line 404.
i chosed 0x5 because it's half 0xb (just a rate controller)
Signed-off-by : Ameen Ali <Ameenali023@gmail.com>
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index 3c651d5..944cf7b 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
pRaInfo->PTModeSS = 3;
else if (pRaInfo->HighestRate > 0x0b)
pRaInfo->PTModeSS = 2;
- else if (pRaInfo->HighestRate > 0x0b)
+ else if (pRaInfo->HighestRate > 0x5)
pRaInfo->PTModeSS = 1;
else
pRaInfo->PTModeSS = 0;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
2015-02-25 16:34 Ameen Ali
@ 2015-03-20 12:48 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-03-20 12:48 UTC (permalink / raw)
To: Ameen Ali; +Cc: devel, linux-kernel
On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
> i chosed 0x5 because it's half 0xb (just a rate controller)
> Signed-off-by : Ameen Ali <Ameenali023@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
How do you know this is correct?
Also, we need a blank line before the signed-off-by line and your
subject should give us a chance to know what driver is being changed, as
well as the subsystem.
Also, where are patches 1/3 and 2/3?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-20 14:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-24 21:00 [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404 Ameen Ali
2015-02-24 22:10 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-02-25 16:34 Ameen Ali
2015-03-20 12:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox