From: Greg KH <gregkh@linuxfoundation.org>
To: Tapasweni Pathak <tapaswenipathak@gmail.com>
Cc: vinc94@gmail.com, roberta.dobrescu@gmail.com,
sachin.kamat@samsung.com, ebru.akagunduz@gmail.com,
damm+renesas@opensource.se, chris@rorvick.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC
Date: Tue, 24 Feb 2015 15:25:00 -0800 [thread overview]
Message-ID: <20150224232500.GA24927@kroah.com> (raw)
In-Reply-To: <20150220131336.GA22731@kt-Inspiron-3542>
On Fri, Feb 20, 2015 at 06:43:53PM +0530, Tapasweni Pathak wrote:
> To avoid deadlock, do not call blocking functions with spinlocks held.
>
> Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
> doesn't have enough free pages but will not sleep and hence deadlock can
> be avoided.
>
> Found by Coccinelle.
>
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> ---
> Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?
No, this is fine, nice fix.
thanks,
greg k-h
prev parent reply other threads:[~2015-02-24 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:13 [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC Tapasweni Pathak
2015-02-24 23:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224232500.GA24927@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@rorvick.com \
--cc=damm+renesas@opensource.se \
--cc=devel@driverdev.osuosl.org \
--cc=ebru.akagunduz@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=roberta.dobrescu@gmail.com \
--cc=sachin.kamat@samsung.com \
--cc=tapaswenipathak@gmail.com \
--cc=vinc94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox