From: Ingo Molnar <mingo@kernel.org>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Matt Fleming <matt.fleming@intel.com>,
Kees Cook <keescook@chromium.org>,
Junjie Mao <eternal.n08@gmail.com>,
linux-doc@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above 4G
Date: Wed, 25 Feb 2015 11:31:32 +0100 [thread overview]
Message-ID: <20150225103132.GB554@gmail.com> (raw)
In-Reply-To: <20150224215501.GB9758@codeblueprint.co.uk>
* Matt Fleming <matt@codeblueprint.co.uk> wrote:
> On Sun, 22 Feb, at 07:43:48PM, Yinghai Lu wrote:
> > Index: linux-2.6/arch/x86/boot/header.S
> > ===================================================================
> > --- linux-2.6.orig/arch/x86/boot/header.S
> > +++ linux-2.6/arch/x86/boot/header.S
> > @@ -301,7 +301,7 @@ _start:
> > # Part 2 of the header, from the old setup.S
> >
> > .ascii "HdrS" # header signature
> > - .word 0x020d # header version number (>= 0x0105)
> > + .word 0x020e # header version number (>= 0x0105)
> > # or else old loadlin-1.5 will fail)
> > .globl realmode_swtch
> > realmode_swtch: .word 0, 0 # default_switch, SETUPSEG
> > @@ -449,6 +449,7 @@ pref_address: .quad LOAD_PHYSICAL_ADDR
> > #endif
> > init_size: .long INIT_SIZE # kernel initialization size
> > handover_offset: .long 0 # Filled in by build.c
> > +ext_code32_start: .long 0 # werid one!
>
> How about a comment like, "# Upper 32-bits of code32_start" ?
Also, in the Linux kernel we should not go about inventing
new English words like 'werid', right?
Thanks,
Ingo
next prev parent reply other threads:[~2015-02-25 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 3:43 [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above 4G Yinghai Lu
2015-02-24 21:55 ` Matt Fleming
2015-02-25 0:31 ` Yinghai Lu
2015-02-25 12:57 ` Matt Fleming
2015-02-25 10:31 ` Ingo Molnar [this message]
2015-02-25 12:57 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225103132.GB554@gmail.com \
--to=mingo@kernel.org \
--cc=corbet@lwn.net \
--cc=eternal.n08@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox