Re: [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above 4G

[Matt Fleming <matt@codeblueprint.co.uk>]

On Wed, 25 Feb, at 11:31:32AM, Ingo Molnar wrote:
> 
> * Matt Fleming <matt@codeblueprint.co.uk> wrote:
> 
> > On Sun, 22 Feb, at 07:43:48PM, Yinghai Lu wrote:
> > > Index: linux-2.6/arch/x86/boot/header.S
> > > ===================================================================
> > > --- linux-2.6.orig/arch/x86/boot/header.S
> > > +++ linux-2.6/arch/x86/boot/header.S
> > > @@ -301,7 +301,7 @@ _start:
> > >  	# Part 2 of the header, from the old setup.S
> > >  
> > >  		.ascii	"HdrS"		# header signature
> > > -		.word	0x020d		# header version number (>= 0x0105)
> > > +		.word	0x020e		# header version number (>= 0x0105)
> > >  					# or else old loadlin-1.5 will fail)
> > >  		.globl realmode_swtch
> > >  realmode_swtch:	.word	0, 0		# default_switch, SETUPSEG
> > > @@ -449,6 +449,7 @@ pref_address:		.quad LOAD_PHYSICAL_ADDR
> > >  #endif
> > >  init_size:		.long INIT_SIZE		# kernel initialization size
> > >  handover_offset:	.long 0			# Filled in by build.c
> > > +ext_code32_start:	.long 0			# werid one!
> >   
> > How about a comment like, "# Upper 32-bits of code32_start" ?
> 
> Also, in the Linux kernel we should not go about inventing 
> new English words like 'werid', right?

Yeah, my intention is to replace "werid one" with the comment I
suggested above.

-- 
Matt Fleming, Intel Open Source Technology Center