From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbbBYOVh (ORCPT ); Wed, 25 Feb 2015 09:21:37 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:39833 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbbBYOVf (ORCPT ); Wed, 25 Feb 2015 09:21:35 -0500 Date: Wed, 25 Feb 2015 15:21:30 +0100 From: Richard Cochran To: Stathis Voukelatos Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, abrestic@chromium.org Subject: Re: [PATCH v2 0/3] net: Linn Ethernet Packet Sniffer driver Message-ID: <20150225142130.GA7703@localhost.localdomain> References: <20150218210830.GA7778@localhost.localdomain> <54EAF4D4.4090505@linn.co.uk> <20150225095056.GB4293@localhost.localdomain> <54EDA997.1080005@linn.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54EDA997.1080005@linn.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 10:53:11AM +0000, Stathis Voukelatos wrote: > On 25/02/15 09:50, Richard Cochran wrote: > > > >The Linux kernel already fully supports this kind of application via > >the SIOCSHWTSTAMP, SO_TIMESTAMPING, and PHC mechanisms. We certainly > >don't need another another interface just for someone's warped > >hardware design. > > > >I suggest that you find a way to make your HW work within the existing > >frame work. > > The driver already uses that framework for returning timestamps to > user space. It does not introduce any new interface. No, it only abuses the interfaces that we already have. The time stamp handling is not "within the existing frame work" by any means. However, there is a way to integrate this hardware properly... > The H/W could not support that: With these new explanations, now I understand the code and how this is supposed to work. I'll put further comments in a reply to your newer series. Thanks, Richard