From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbbBYOrO (ORCPT ); Wed, 25 Feb 2015 09:47:14 -0500 Received: from foss.arm.com ([217.140.101.70]:37759 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbBYOrM (ORCPT ); Wed, 25 Feb 2015 09:47:12 -0500 Date: Wed, 25 Feb 2015 14:47:37 +0000 From: Lorenzo Pieralisi To: Daniel Lezcano Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" Subject: Re: [PATCH 2/2] drivers: cpuidle: add driver/device checks in cpuidle_enter_freeze() Message-ID: <20150225144737.GD20214@red-moon> References: <1424800730-32059-1-git-send-email-lorenzo.pieralisi@arm.com> <1424800730-32059-3-git-send-email-lorenzo.pieralisi@arm.com> <54EDDC99.40208@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54EDDC99.40208@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 02:30:49PM +0000, Daniel Lezcano wrote: > On 02/24/2015 06:58 PM, Lorenzo Pieralisi wrote: > > The changes in commit: > > > > 381063133246 ("PM / sleep: Re-implement suspend-to-idle handling") > > > > let suspend-to-idle code bypass the cpuidle_select() function to > > enter the deepest idle state. The sanity checks carried out in > > cpuidle_select() are bypassed too and this can cause breakage > > on systems that try to suspend-to-idle with no registered cpuidle > > driver. > > > > This patch factors out a function cpuidle_device_disabled() that > > is used to carry out sanity checks (ie CPUidle is disabled on the > > cpu executing the code) in both cpuidle_select() and cpuidle_enter_freeze() > > so that the checks are unified and carried out in both control paths. > > > > Cc: Rafael J. Wysocki > > Cc: Daniel Lezcano > > Signed-off-by: Lorenzo Pieralisi > > --- > > drivers/cpuidle/cpuidle.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c > > index f47edc6c..344fe6c 100644 > > --- a/drivers/cpuidle/cpuidle.c > > +++ b/drivers/cpuidle/cpuidle.c > > @@ -44,6 +44,12 @@ void disable_cpuidle(void) > > off = 1; > > } > > > > +static bool cpuidle_device_disabled(struct cpuidle_driver *drv, > > + struct cpuidle_device *dev) > > +{ > > + return (off || !initialized || !drv || !dev || !dev->enabled); > > +} > > This is getting a bit fuzzy IMO. What means disabled ? :) Well, that's just the current checks in cpuidle_select() (that by the way is supposed to return an index) merged together with a function name, to reuse the same checks in cpuidle_enter_freeze(). I have no problem leaving the checks as they are at the moment and replicate them in cpuidle_enter_freeze() but given your remark below, we should do something different in there. > > > /** > > * cpuidle_play_dead - cpu off-lining > > * > > @@ -124,6 +130,11 @@ void cpuidle_enter_freeze(void) > > struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev); > > int index; > > I think this is exploding before because of dev == NULL in the line above. Yes, good point so my attempt at consolidating the sanity checks above is not valid, but something has to be done regardless. Lorenzo > > + if (cpuidle_device_disabled(drv, dev)) { > > + arch_cpu_idle(); > > + return; > > + } > > + > > /* > > * Find the deepest state with ->enter_freeze present, which guarantees > > * that interrupts won't be enabled when it exits and allows the tick to > > @@ -202,11 +213,8 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv, > > */ > > int cpuidle_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > > { > > - if (off || !initialized) > > - return -ENODEV; > > - > > - if (!drv || !dev || !dev->enabled) > > - return -EBUSY; > > + if (cpuidle_device_disabled(drv, dev)) > > + return -1; > > > > return cpuidle_curr_governor->select(drv, dev); > > } > > > > > -- > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog > >