Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.

Lee Jones
2015-02-25T15:50:19Z

On Wed, 25 Feb 2015, Peter Griffin wrote:

> Hi Lee,
>
> On Wed, 25 Feb 2015, Lee Jones wrote:
>
> > > + resets = <&powerdown STIH407_USB3_POWERDOWN>,
> > > + <&softreset STIH407_MIPHY2_SOFTRESET>;
> > > + reset-names = "powerdown",
> > > + "softreset";
> >
> > Nit: What's the purpose of having these on separate lines?
>
> The only reason was to stay aligned with the example in
> Documentation/devicetree/bindings/usb/dwc3-st.txt.

But didn't you author that too? :)

I would change them both. No need to force a line wrap if it's not required.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog