* [PATCH] mfd: da9150: Constify struct regmap_config
@ 2015-02-24 9:39 Krzysztof Kozlowski
2015-02-25 15:31 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-24 9:39 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, linux-kernel; +Cc: Krzysztof Kozlowski
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/mfd/da9150-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c
index 4d757b97ef9a..5549817df32e 100644
--- a/drivers/mfd/da9150-core.c
+++ b/drivers/mfd/da9150-core.c
@@ -95,7 +95,7 @@ static const struct regmap_range_cfg da9150_range_cfg[] = {
},
};
-static struct regmap_config da9150_regmap_config = {
+static const struct regmap_config da9150_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.ranges = da9150_range_cfg,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: da9150: Constify struct regmap_config
2015-02-24 9:39 [PATCH] mfd: da9150: Constify struct regmap_config Krzysztof Kozlowski
@ 2015-02-25 15:31 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-02-25 15:31 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Samuel Ortiz, linux-kernel
On Tue, 24 Feb 2015, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/da9150-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c
> index 4d757b97ef9a..5549817df32e 100644
> --- a/drivers/mfd/da9150-core.c
> +++ b/drivers/mfd/da9150-core.c
> @@ -95,7 +95,7 @@ static const struct regmap_range_cfg da9150_range_cfg[] = {
> },
> };
>
> -static struct regmap_config da9150_regmap_config = {
> +static const struct regmap_config da9150_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .ranges = da9150_range_cfg,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-25 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-24 9:39 [PATCH] mfd: da9150: Constify struct regmap_config Krzysztof Kozlowski
2015-02-25 15:31 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox