From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbBYPbT (ORCPT ); Wed, 25 Feb 2015 10:31:19 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:39308 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbbBYPbS (ORCPT ); Wed, 25 Feb 2015 10:31:18 -0500 Date: Wed, 25 Feb 2015 15:31:07 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: da9150: Constify struct regmap_config Message-ID: <20150225153107.GC6688@x1> References: <1424770773-7228-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424770773-7228-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Feb 2015, Krzysztof Kozlowski wrote: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/da9150-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c > index 4d757b97ef9a..5549817df32e 100644 > --- a/drivers/mfd/da9150-core.c > +++ b/drivers/mfd/da9150-core.c > @@ -95,7 +95,7 @@ static const struct regmap_range_cfg da9150_range_cfg[] = { > }, > }; > > -static struct regmap_config da9150_regmap_config = { > +static const struct regmap_config da9150_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > .ranges = da9150_range_cfg, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog