Re: [PATCH V6 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

Thierry Reding
2014-12-02T09:47:50Z

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

On Mon, Nov 24, 2014 at 04:17:17PM -0800, Andrew Bresticker wrote:
> The Tegra xHCI controller's firmware communicates requests to the host
> processor through a mailbox interface. While there is only a single
> physical channel, messages sent by the controller can be divided
> into two groups: those intended for the PHY driver and those intended
> for the host-controller driver. The requesting driver is assigned
> one of two virtual channels when the single physical channel is
> requested. All incoming messages are sent to both virtual channels.
>
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> ---
> Thierry,
>
> I've left this as a separate driver because I don't think it should be
> combined with the xHCI host. Stephen and I discussed this earlier in
> review of v1 of this series and he agreed that the mailbox belongs in
> its own DT node and driver.

My objection wasn't strictly against merging the drivers. What I don't
want to see is two devices sharing the same memory-mapped regions in DT.

That's based on earlier discussion with Stephen as well, because we have
had the same problem with USB and USB-PHY before. Unless I completely
misinterpreted we came to the conclusion that we should avoid this in
the future.

Like I said, this doesn't mean that both need to be in the same driver.
We could use MFD for example, or provide an entry point in the mailbox
driver that can be called from the XUSB driver to instantiate the
mailbox (which is really the same as MFD).

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]