From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753124AbbBYQHZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Feb 2015 11:07:25 -0500
Received: from mail.skyhub.de ([78.46.96.112]:56768 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752440AbbBYQHY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Feb 2015 11:07:24 -0500
Date: Wed, 25 Feb 2015 17:06:21 +0100
From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] x86: entry.S: tidy up several suboptimal insns
Message-ID: <20150225160621.GG3226@pd.tnic>
References: <1424803895-4420-1-git-send-email-dvlasenk@redhat.com>
 <CALCETrVretXX1Wgx9TNQH67XH=M6fGA+L+7agyp0Fm8503Ey9w@mail.gmail.com>
 <54ED00B5.3020203@zytor.com>
 <20150225092043.GB16165@gmail.com>
 <20150225094312.2cfff453@gandalf.local.home>
 <CAK1hOcNgDk7oXx0UqzYJNhxHCdauKw8n=YgHJ-kHj7wUMhvLKw@mail.gmail.com>
 <20150225110129.5d099cd8@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150225110129.5d099cd8@gandalf.local.home>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 25, 2015 at 11:01:29AM -0500, Steven Rostedt wrote:
> I'm just curious, do all these micro optimizations have any real impact
> on real use cases?
> 
> That is, if we are going to make the system less robust, shouldn't we
> show that it has real benefit?

I'm wondering the same thing this whole time. Is it even worth
the bother if those "improvements" don't show on any reasonable
benchmark...? And maybe we should benchmark stuff first and then
apply.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--