Re: [RFT RESEND 1/4] power_supply: twl4030_madc: Check return value of power_supply_register

Sebastian Reichel
2015-02-25T21:22:39Z

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi Krzysztof,

On Fri, Feb 20, 2015 at 02:32:22PM +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
>
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Fixes: da0a00ebc239 ("power: Add twl4030_madc battery driver.")
> Cc: <stable@vger.kernel.org>

Thanks, added patches 1-4 to fixes branch.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]