Re: Mess in the /sysfs: class/power_supply/bq2415x

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

Hi Pavel,

On Sat, Jan 31, 2015 at 10:39:19PM +0100, Pavel Machek wrote:
> So we have multiple values in one sysfs file:
> 
> root@n900:/sys/class/power_supply# cat bq24150a-0/registers
> 0x00=0x50
> 0x01=0xc8
> 0x02=0x8e
> 0x03=0x4b
> 0x04=0x99
> 
> (should this go to debugfs somewhere?)

I guess this should be dropped in favour of debugfs. A standardized
debugfs node will be exported automatically if the driver is
converted to regmap.

> Unobvious and undocumented entries:
> 
> root@n900:/sys/class/power_supply# cat bq24150a-0/boost_status
> 0
> pavel@duo:/data/l/linux-n900$ grep -ri boost_status Documentation/
> pavel@duo:/data/l/linux-n900$ grep -ri termination_current Documentation/
> pavel@duo:/data/l/linux-n900$ grep -ri current_now Documentation/
> pavel@duo:/data/l/linux-n900$ grep -ri time_to_empty_avg Documentation/
> pavel@duo:/data/l/linux-n900$

Anton seems to have missed making Pali to write a Documentation
patch. Pali: Can you do so, please?

> And different units in different parts of tree:
> 
> (these are mA)
> 
> root@n900:/sys/class/power_supply# cat bq24150a-0/current_limit
> 1800
> root@n900:/sys/class/power_supply# cat bq24150a-0/termination_current
> 100
> 
> (and this is in uA)
> 
> root@n900:/sys/class/power_supply# cat bq27200-0/current_now
> 12138
> 
> (I believe uA is right, so it is bq24150a that should be fixed....?)

> Ok, of course questions are: do we need to do something with it? If
> so, what?

For consistency it should be uA, but I guess this would introduce a
regression for Maemo people. Pali?

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]