From: Borislav Petkov <bp@suse.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] PCI/AER: Avoid info leak in __print_tlp_header
Date: Wed, 25 Feb 2015 23:59:00 +0100 [thread overview]
Message-ID: <20150225225859.GB19236@pd.tnic> (raw)
In-Reply-To: <CAErSpo5WwP1z+rzXzEM8_bJ2sq7rixOWiF5CqYYSK32r0sVYuw@mail.gmail.com>
On Wed, Feb 25, 2015 at 12:18:14PM -0800, Bjorn Helgaas wrote:
> Why are we worrying about byte order here at all? I'd think we could
> just print t->dw0 directly with %08x.
Right, my only concern is since this is user-facing, someone/something
might depend on its format/byte order. But since no one has complained
about the bug so far, we might just as well do the simple thing and just
print t->dwX.
Btw, Bjorn, when applying the final version, please add the stable tag
too.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-02-25 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 22:50 [PATCH] PCI/AER: Avoid info leak in __print_tlp_header Rasmus Villemoes
2015-02-25 18:54 ` Borislav Petkov
2015-02-25 20:18 ` Bjorn Helgaas
2015-02-25 21:06 ` Luck, Tony
2015-02-25 22:59 ` Borislav Petkov [this message]
2015-02-26 8:55 ` [PATCH v2] " Rasmus Villemoes
2015-02-26 12:27 ` Borislav Petkov
2015-03-06 18:33 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225225859.GB19236@pd.tnic \
--to=bp@suse.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox