From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbbBZGGV (ORCPT ); Thu, 26 Feb 2015 01:06:21 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:36289 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbbBZGGU (ORCPT ); Thu, 26 Feb 2015 01:06:20 -0500 Date: Wed, 25 Feb 2015 22:06:16 -0800 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gabriele Mazzotta , mjg59@srcf.ucam.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, A.Sloman@cs.bham.ac.uk, computersforpeace@gmail.com, dan.carpenter@oracle.com Subject: Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight Message-ID: <20150226060616.GA7331@fury.dvhart.com> References: <1424343509-13639-1-git-send-email-gabriele.mzt@gmail.com> <201502221204.24003@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201502221204.24003@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 22, 2015 at 12:04:23PM +0100, Pali Rohár wrote: > On Thursday 19 February 2015 11:58:29 Gabriele Mazzotta wrote: > > This patch adds the support for the configuration of the > > keyboard backlight on supported Dell laptops. > > > > With this patch it is possible to set: > > * keyboard backlight level > > * timeout after which the backlight will be automatically > > turned off * input activity triggers (keyboard, touchpad, > > mouse) that enable the backlight * ambient light settings > > > > The settings are exposed via > > /sys/class/leds/dell::kbd_backlight/ > > > > The code is based on the newly released documentation by Dell > > in the libsmbios project. > > > > Signed-off-by: Pali Rohár > > Signed-off-by: Gabriele Mazzotta > > Cc: Dan Carpenter > > --- > > .../ABI/testing/sysfs-platform-dell-laptop | 69 ++ > > drivers/platform/x86/dell-laptop.c | 1089 > > +++++++++++++++++++- 2 files changed, 1152 insertions(+), 6 > > deletions(-) > > create mode 100644 > > Documentation/ABI/testing/sysfs-platform-dell-laptop > > > > This patch is same as combination of previous, just contains all > changes in single patch file. Difference between v3.19-rc5 and > current version is just als code was moved to separate functions > and als backlight can be enabled via new sysfs attribute (like in > second patch which was sent). > > I tested this patch on top of linus tree (commit 79513d0) and > keyboard backlight works fine. > > Darren, what do you think, can be this patch which brings > keyboard backlight support finally moved to mainline kernel? So sorry for the delay folks, bad week :( This landed too late for 3.20... her durr 4.0, but should make 4.1. Expect to see it in next in the next few days. -- Darren Hart Intel Open Source Technology Center