From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbbBZLBg (ORCPT ); Thu, 26 Feb 2015 06:01:36 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:39489 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762AbbBZLBe (ORCPT ); Thu, 26 Feb 2015 06:01:34 -0500 Date: Thu, 26 Feb 2015 11:01:19 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Sangbeom Kim , Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] mfd: sec: Cleanup unused RTC fields: ono, WTSR and SMPL Message-ID: <20150226110119.GM6688@x1> References: <1424942031-28370-1-git-send-email-k.kozlowski@samsung.com> <1424942031-28370-2-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424942031-28370-2-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Feb 2015, Krzysztof Kozlowski wrote: > The WTSR (Watchdog Timer Software Reset) and SMPL (Sudden Momentary > Power Loss) were removed from rtc-s5m driver because they were not used. > Remove them (and on/off interrupt) from main MFD driver and header. > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > 1. Split out ENOMEM message removal to separate patch (suggested by > Lee). > --- > drivers/mfd/sec-core.c | 1 - > include/linux/mfd/samsung/core.h | 9 --------- > 2 files changed, 10 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 0a7bc43db4e4..423a2d3da4b2 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -333,7 +333,6 @@ static int sec_pmic_probe(struct i2c_client *i2c, > } > if (pdata) { > sec_pmic->device_type = pdata->device_type; > - sec_pmic->ono = pdata->ono; > sec_pmic->irq_base = pdata->irq_base; > sec_pmic->wakeup = pdata->wakeup; > sec_pmic->pdata = pdata; > diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h > index 3fdb7cfbffb3..75115384f3fc 100644 > --- a/include/linux/mfd/samsung/core.h > +++ b/include/linux/mfd/samsung/core.h > @@ -58,13 +58,7 @@ enum sec_device_type { > * @irq_base: Base IRQ number for device, required for IRQs > * @irq: Generic IRQ number for device > * @irq_data: Runtime data structure for IRQ controller > - * @ono: Power onoff IRQ number for s5m87xx > * @wakeup: Whether or not this is a wakeup device > - * @wtsr_smpl: Whether or not to enable in RTC driver the Watchdog > - * Timer Software Reset (registers set to default value > - * after PWRHOLD falling) and Sudden Momentary Power Loss > - * (PMIC will enter power on sequence after short drop in > - * VBATT voltage). > */ > struct sec_pmic_dev { > struct device *dev; > @@ -77,9 +71,7 @@ struct sec_pmic_dev { > int irq; > struct regmap_irq_chip_data *irq_data; > > - int ono; > bool wakeup; > - bool wtsr_smpl; > }; > > int sec_irq_init(struct sec_pmic_dev *sec_pmic); > @@ -95,7 +87,6 @@ struct sec_platform_data { > int irq_base; > int (*cfg_pmic_irq)(void); > > - int ono; > bool wakeup; > bool buck_voltage_lock; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog