From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673AbbBZLCB (ORCPT ); Thu, 26 Feb 2015 06:02:01 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:39159 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbbBZLB7 (ORCPT ); Thu, 26 Feb 2015 06:01:59 -0500 Date: Thu, 26 Feb 2015 11:01:44 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Sangbeom Kim , Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] mfd: sec: Remove unnecessary out of memory message Message-ID: <20150226110144.GN6688@x1> References: <1424942031-28370-1-git-send-email-k.kozlowski@samsung.com> <1424942031-28370-3-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424942031-28370-3-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Feb 2015, Krzysztof Kozlowski wrote: > There is no need to print additional ENOMEM message for > sec_platform_data allocation failure. > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > 1. New patch. > --- > drivers/mfd/sec-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 423a2d3da4b2..2253d44e631c 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -267,10 +267,8 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata( > struct sec_platform_data *pd; > > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > - if (!pd) { > - dev_err(dev, "could not allocate memory for pdata\n"); > + if (!pd) > return ERR_PTR(-ENOMEM); > - } > > /* > * ToDo: the 'wakeup' member in the platform data is more of a linux -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog