From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753719AbbBZMGE (ORCPT ); Thu, 26 Feb 2015 07:06:04 -0500 Received: from mail.skyhub.de ([78.46.96.112]:53189 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbBZMGB (ORCPT ); Thu, 26 Feb 2015 07:06:01 -0500 Date: Thu, 26 Feb 2015 13:04:57 +0100 From: Borislav Petkov To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Tiejun Chen , Paolo Bonzini , kvm ML , lkml Subject: Re: [PATCH] KVM: SVM: fix interrupt injection (apic->isr_count always 0) Message-ID: <20150226120457.GB3314@pd.tnic> References: <20150225160056.GF3226@pd.tnic> <20150225194140.GA9777@potion.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150225194140.GA9777@potion.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 08:41:41PM +0100, Radim Krčmář wrote: > this patch should fix it. Yap, seems so :-) > ---8<--- > In commit b4eef9b36db4, we started to use hwapic_isr_update() != NULL > instead of kvm_apic_vid_enabled(vcpu->kvm). This didn't work because > SVM had it defined and "apicv" path in apic_{set,clear}_isr() does not > change apic->isr_count, because it should always be 1. The initial > value of apic->isr_count was based on kvm_apic_vid_enabled(vcpu->kvm), > which is always 0 for SVM, so KVM could have injected interrupts when it > shouldn't. > > Fix it by setting SVM's hwapic_isr_update to NULL and make the initial > isr_count depend on hwapic_isr_update() for good measure. > > Fixes: b4eef9b36db4 ("kvm: x86: vmx: NULL out hwapic_isr_update() in case of !enable_apicv") > Reported-by: Borislav Petkov Reported-and-tested-by: Borislav Petkov > Signed-off-by: Radim Krčmář Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --