From: Andrew Morton <akpm@linux-foundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: mfasheh@suse.com, jlbec@evilplan.org, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'
Date: Thu, 26 Feb 2015 13:33:29 -0800 [thread overview]
Message-ID: <20150226133329.8a80c302d3ec014a2b0d58ff@linux-foundation.org> (raw)
In-Reply-To: <20150223103810.GA16869@devel.8.8.4.4>
On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn@gmail.com> wrote:
> Use 'retval' instead of 'status'.
>
The patch does a lot more than this. It causes __ocfs2_add_entry to
propagate error codes which were previously dropped on the floor.
Please update the changelog to fully explain the functional changes and
to explain why they are desirable.
After the patch there is still one unchecked call to
ocfs2_journal_access_di() and one unchecked call to
ocfs2_journal_access_db(). Probably these are bugs.
next prev parent reply other threads:[~2015-02-26 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 10:38 [PATCH 1/3] ocfs2: remove unneeded variable 'status' Daeseok Youn
2015-02-26 21:33 ` Andrew Morton [this message]
2015-02-27 9:27 ` DaeSeok Youn
2015-02-27 9:41 ` Richard Weinberger
2015-02-27 10:29 ` DaeSeok Youn
2015-02-28 6:55 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226133329.8a80c302d3ec014a2b0d58ff@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daeseok.youn@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox