From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>
Subject: Re: Trying to use 'perf probe' to debug perf itself
Date: Thu, 26 Feb 2015 11:40:42 -0300 [thread overview]
Message-ID: <20150226144042.GB1079@kernel.org> (raw)
In-Reply-To: <54EEA7C6.3050104@hitachi.com>
Em Thu, Feb 26, 2015 at 01:57:42PM +0900, Masami Hiramatsu escreveu:
> (2015/02/25 22:25), Arnaldo Carvalho de Melo wrote:
> > Em Wed, Feb 25, 2015 at 11:53:16AM +0900, Masami Hiramatsu escreveu:
> >> (2015/02/25 3:49), Arnaldo Carvalho de Melo wrote:
> >> Hmm, strange. Could you tell me the version of your kernel?
> > [root@ssdandy ~]# uname -r
> > 3.10.0-210.el7.x86_64
> >> It seems that the kernel newer than 3.14 supports uprobes with
> >> memory dereference (e.g. -32(%sp) )feature.
> > Right, that must be the case, will test, but then, would it be possible
> > for the kernel, in such cases, return something line EOPNOTSUP?
> Yeah, but for now, it is already supported in kernel.
> Of cause we can try to test feature with adding temporary event
> from perftools too.
Yeah, capability querying is done in several places in tools/perf/
already, like when checking if we have perf_event_attr enabled features,
such as sample_id_all, etc.
Sometimes we can fallback to alternative mechanisms, sometimes we just
need to provide a less cryptic message.
> > I will try to figure out a better error message on the tooling side,
> > something like:
> > . Realize we're asking for memory dereference in uprobes
> > . If it fails with EINVAL, check the kernel version and say something
> > like:
> >
> > Please upgrade your kernel to at least x.y.z to have access to feature
> > FOO_BAR.
> OK, it may be worth for users (I'm not sure RHEL can update their kernel
> to include that enhancement)
That may be possible, will check with Jiri if we can include that in a
future backport.
Talking about these tools in conferences will make more people try the
things mentioned, and as we talk about the latest and greatest, we need
to try harder to handle error paths in a better way, providing less
cryptic messages.
Rebuilding a newer kernel now to retry all this, thanks!
- Arnaldo
next prev parent reply other threads:[~2015-02-26 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:49 Trying to use 'perf probe' to debug perf itself Arnaldo Carvalho de Melo
2015-02-25 2:53 ` Masami Hiramatsu
2015-02-25 13:25 ` Arnaldo Carvalho de Melo
2015-02-26 4:57 ` Masami Hiramatsu
2015-02-26 14:40 ` Arnaldo Carvalho de Melo [this message]
2015-02-28 2:53 ` [PATCH perf/core ] perf-probe: Warn if given uprobe event accesses memory on older kernel Masami Hiramatsu
2015-02-28 3:21 ` Masami Hiramatsu
2015-02-28 20:45 ` Arnaldo Carvalho de Melo
2015-03-03 6:25 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226144042.GB1079@kernel.org \
--to=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).