From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
Jerome Marchand <jmarchan@redhat.com>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 0/8] introduce dynamic device creation/removal
Date: Fri, 27 Feb 2015 14:51:09 -0800 [thread overview]
Message-ID: <20150227145109.b5656bdf853c2d283bf9268e@linux-foundation.org> (raw)
In-Reply-To: <1424959843-20409-1-git-send-email-sergey.senozhatsky@gmail.com>
On Thu, 26 Feb 2015 23:10:35 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> Hello,
>
> this patchset introduces dynamic (on demand) zram device add-remove
> functionality via /dev/zram-control interface. Two ioctl commands are
> defined as of now (accessible in user-space via new zram.h header file):
> -- ZRAM_CTL_ADD
> add new device (generates device_id automatically or uses provided
> device_id)
> -- ZRAM_CTL_REMOVE
> remove device (by device_id)
>
> util-linux zramctl update will be done later, after we land this patchset.
>
>
> This also opens a possibility to drop some of sysfs device attrs and FOO_show()
> code duplication in the future, and provide device stats/info via ioctl call
> instead, providing something like (via zram.h):
>
> struct zram_info {
> __u64 orig_data_size;
> __u64 mem_used_total;
> __u64 max_comp_streams;
>
> [..]
> };
>
>
> fill it under ->init_lock in zram_fill_info() (or any other name) function and
> return all device stats at once back to user-space in a single syscall.
>
> This is a long term plan, of course, but I'd like to see sysfs functions go away
> in a year or so. What do you think?
hoo boy. Creating a /dev node and doing ioctls on it is really old
school. So old school that I've forgotten why we don't do it any more.
Hopefully Alan can recall the thinking?
next prev parent reply other threads:[~2015-02-27 22:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 14:10 [PATCH 0/8] introduce dynamic device creation/removal Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 1/8] zram: cosmetic ZRAM_ATTR_RO code formatting tweak Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 2/8] zram: use idr instead of `zram_devices' array Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 3/8] zram: factor out device reset from reset_store() Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 4/8] zram: add dynamic device add/remove functionality Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 5/8] zram: return zram device_id value from zram_add() Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 6/8] zram: allow automatic new zram device_id assignment Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 7/8] zram: remove max_num_devices limitation Sergey Senozhatsky
2015-02-26 14:10 ` [PATCH 8/8] zram: report every added and removed device Sergey Senozhatsky
2015-02-27 22:51 ` Andrew Morton [this message]
2015-02-28 1:33 ` [PATCH 0/8] introduce dynamic device creation/removal Sergey Senozhatsky
2015-02-28 1:50 ` Sergey Senozhatsky
2015-02-28 3:34 ` Sergey Senozhatsky
2015-02-28 4:29 ` Andrew Morton
2015-03-02 14:18 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227145109.b5656bdf853c2d283bf9268e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox