public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: davem@davemloft.net, mugunthanvnm@ti.com, george.cherian@ti.com,
	prabhakar.csengg@gmail.com, varkabhadram@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	grygorii.strashko@ti.com, lokeshvutla@ti.com, mpa@pengutronix.de,
	w-kwok2@ti.com
Subject: Re: [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default
Date: Fri, 27 Feb 2015 08:29:22 -0800	[thread overview]
Message-ID: <20150227162921.GX11056@atomide.com> (raw)
In-Reply-To: <1424813251-31610-2-git-send-email-m-karicheri2@ti.com>

* Murali Karicheri <m-karicheri2@ti.com> [150224 13:31]:
> Keystone netcp driver re-uses davinci mdio driver. So enable it
> by default for keystone netcp driver.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
>  drivers/net/ethernet/ti/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 3bc992c..945a221 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -88,6 +88,7 @@ config TI_CPTS
>  config TI_KEYSTONE_NETCP
>  	tristate "TI Keystone NETCP Core Support"
>  	select TI_CPSW_ALE
> +	select TI_DAVINCI_MDIO
>  	depends on OF
>  	depends on KEYSTONE_NAVIGATOR_DMA && KEYSTONE_NAVIGATOR_QMSS
>  	---help---

These options should be silent Kconfig options if we're selecting
them. Or else you should use depends on instead.

In general using select for driver modules will eventually lead into
randconfig build failures as things change.

Regards,

Tony

  reply	other threads:[~2015-02-27 16:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 21:27 [PATCH net-next 1/2] net: davinci_mdio: don't request io address range Murali Karicheri
2015-02-24 21:27 ` [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default Murali Karicheri
2015-02-27 16:29   ` Tony Lindgren [this message]
2015-02-27 20:56     ` Murali Karicheri
2015-03-02 16:11       ` Tony Lindgren
2015-03-02 21:45         ` Murali Karicheri
2015-03-03  0:04           ` Tony Lindgren
2015-03-11 16:18             ` Murali Karicheri
2015-02-27 15:55 ` [PATCH net-next 1/2] net: davinci_mdio: don't request io address range Lad, Prabhakar
2015-02-27 16:51 ` Tony Lindgren
2015-03-11 16:35   ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227162921.GX11056@atomide.com \
    --to=tony@atomide.com \
    --cc=davem@davemloft.net \
    --cc=george.cherian@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=m-karicheri2@ti.com \
    --cc=mpa@pengutronix.de \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=varkabhadram@gmail.com \
    --cc=w-kwok2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox