public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kan.liang@intel.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, acme@kernel.org
Subject: Re: [RFC PATCH 1/1] proc: introduce /proc/<pid>/lbr_stack
Date: Fri, 27 Feb 2015 09:54:34 -0800	[thread overview]
Message-ID: <20150227175434.GI27767@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150227075829.GC21418@twins.programming.kicks-ass.net>

On Fri, Feb 27, 2015 at 08:58:29AM +0100, Peter Zijlstra wrote:
> On Mon, Feb 23, 2015 at 09:44:48AM -0800, Andi Kleen wrote:
> > On Mon, Feb 23, 2015 at 05:49:57PM +0100, Peter Zijlstra wrote:
> > > On Mon, Feb 23, 2015 at 03:43:41AM +0000, kan.liang@intel.com wrote:
> > > > From: Kan Liang <kan.liang@intel.com>
> > > > 
> > > > Haswell has a new feature that utilizes the existing Last Branch Record
> > > > facility to record call chains. It has been implemented in perf. The
> > > > call chains information is saved during perf event context.
> > > > 
> > > > This patch exposes a /proc/<pid>/lbr_stack file that shows the saved LBR
> > > > call chain information.
> > > 
> > > But why? I mean, this thing is only useful if you have a concurrently
> > > running perf record that selects the LBR-stack stuff.
> > > 
> > > And if you have that, you might as well look at its output instead. Why
> > > add this unconditional proc file that doesn't function on its own?
> > 
> > perf record doesn't show where you're currently blocked.
> 
> Of course it does; look at perf inject -s.

Trace points don't support the LBR stack.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2015-02-27 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23  3:43 [RFC PATCH 1/1] proc: introduce /proc/<pid>/lbr_stack kan.liang
2015-02-23 16:49 ` Peter Zijlstra
2015-02-23 17:44   ` Andi Kleen
2015-02-27  7:58     ` Peter Zijlstra
2015-02-27 17:54       ` Andi Kleen [this message]
2015-02-27 22:05         ` Peter Zijlstra
2015-02-27 23:57           ` Andi Kleen
2015-02-28 10:18             ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227175434.GI27767@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox