From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kan.liang@intel.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, acme@kernel.org
Subject: Re: [RFC PATCH 1/1] proc: introduce /proc/<pid>/lbr_stack
Date: Fri, 27 Feb 2015 15:57:02 -0800 [thread overview]
Message-ID: <20150227235702.GJ27767@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150227220545.GT5029@twins.programming.kicks-ass.net>
On Fri, Feb 27, 2015 at 11:05:45PM +0100, Peter Zijlstra wrote:
> On Fri, Feb 27, 2015 at 09:54:34AM -0800, Andi Kleen wrote:
> > > > perf record doesn't show where you're currently blocked.
> > >
> > > Of course it does; look at perf inject -s.
> >
> > Trace points don't support the LBR stack.
>
> Yes, indeed. But would it not make much more sense to squirrel the LBR
> state into sched:sched_switch and teach that inject -s thing to dtrt,
> than to make a proc file that's available on all archs but will only
> work on 1-2 x86 uarchs and only if you're also running the right magic
> perf record at the same time?
Yes. It would be nice to capture the whole PMU state in trace points.
There are use models for this where it can work better than
sampling.
But that would be a lot bigger project than this simple file,
which is already quite useful with minimal effort.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2015-02-27 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 3:43 [RFC PATCH 1/1] proc: introduce /proc/<pid>/lbr_stack kan.liang
2015-02-23 16:49 ` Peter Zijlstra
2015-02-23 17:44 ` Andi Kleen
2015-02-27 7:58 ` Peter Zijlstra
2015-02-27 17:54 ` Andi Kleen
2015-02-27 22:05 ` Peter Zijlstra
2015-02-27 23:57 ` Andi Kleen [this message]
2015-02-28 10:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227235702.GJ27767@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox