From: Greg KH <gregkh@linuxfoundation.org>
To: Sean Darcy <darcys22@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis
Date: Sat, 28 Feb 2015 07:09:03 -0800 [thread overview]
Message-ID: <20150228150903.GA22112@kroah.com> (raw)
In-Reply-To: <1425133913-9967-1-git-send-email-darcys22@gmail.com>
On Sat, Feb 28, 2015 at 06:31:53AM -0800, Sean Darcy wrote:
> This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c
> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Sean Darcy <darcys22@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..0408a12 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -412,7 +412,7 @@ struct octeon_hcd {
> type c; \
> while (1) { \
> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> - if (c.s.field op (value)) { \
> + if (c.s.field op(value)) { \
This isn't a "real" function, and I don't think this change will build
properly. Did you test it?
thanks,
greg k-h
prev parent reply other threads:[~2015-02-28 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 14:31 [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis Sean Darcy
2015-02-28 15:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150228150903.GA22112@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=darcys22@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox