From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbbB1PJI (ORCPT ); Sat, 28 Feb 2015 10:09:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbbB1PJG (ORCPT ); Sat, 28 Feb 2015 10:09:06 -0500 Date: Sat, 28 Feb 2015 07:09:03 -0800 From: Greg KH To: Sean Darcy Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis Message-ID: <20150228150903.GA22112@kroah.com> References: <1425133913-9967-1-git-send-email-darcys22@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425133913-9967-1-git-send-email-darcys22@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 28, 2015 at 06:31:53AM -0800, Sean Darcy wrote: > This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c > WARNING: space prohibited between function name and open parenthesis '(' > > Signed-off-by: Sean Darcy > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c > index 1daeb31..0408a12 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -412,7 +412,7 @@ struct octeon_hcd { > type c; \ > while (1) { \ > c.u32 = __cvmx_usb_read_csr32(usb, address); \ > - if (c.s.field op (value)) { \ > + if (c.s.field op(value)) { \ This isn't a "real" function, and I don't think this change will build properly. Did you test it? thanks, greg k-h