* [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis
@ 2015-02-28 14:31 Sean Darcy
2015-02-28 15:09 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sean Darcy @ 2015-02-28 14:31 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Sean Darcy
This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Sean Darcy <darcys22@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 1daeb31..0408a12 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -412,7 +412,7 @@ struct octeon_hcd {
type c; \
while (1) { \
c.u32 = __cvmx_usb_read_csr32(usb, address); \
- if (c.s.field op (value)) { \
+ if (c.s.field op(value)) { \
result = 0; \
break; \
} else if (cvmx_get_cycle() > done) { \
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis
2015-02-28 14:31 [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis Sean Darcy
@ 2015-02-28 15:09 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-02-28 15:09 UTC (permalink / raw)
To: Sean Darcy; +Cc: devel, linux-kernel
On Sat, Feb 28, 2015 at 06:31:53AM -0800, Sean Darcy wrote:
> This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c
> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Sean Darcy <darcys22@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..0408a12 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -412,7 +412,7 @@ struct octeon_hcd {
> type c; \
> while (1) { \
> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> - if (c.s.field op (value)) { \
> + if (c.s.field op(value)) { \
This isn't a "real" function, and I don't think this change will build
properly. Did you test it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-28 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-28 14:31 [PATCH] Staging: Octeon USB: Fix space prohibited between function name and open parenthesis Sean Darcy
2015-02-28 15:09 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox