From: Sebastian Reichel <sre@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq27x00_battery: add bq27510 support
Date: Sat, 28 Feb 2015 17:12:15 +0100 [thread overview]
Message-ID: <20150228161215.GB886@earth> (raw)
In-Reply-To: <20150228132223.GE4094@piout.net>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Hi Alexandre,
On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote:
> Hi,
>
> On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote :
> > > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di)
> > > {
> > > int cyct;
> > >
> > > +
> >
> > spurious newline.
> >
> > > + if (di->chip == BQ27510)
> > > + cyct = bq27x00_read(di, BQ27510_REG_CYCT, false);
> > > cyct = bq27x00_read(di, BQ27x00_REG_CYCT, false);
> >
> > missing else?
> >
>
> Indeed, I just sent v2. However, I'm not too happy with all that if/else
> layering in this driver. I'll try to rework it so that it scales better.
Thanks, that would be nice.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-02-28 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 14:08 [PATCH] power: bq27x00_battery: add bq27510 support Alexandre Belloni
2015-02-25 22:17 ` Sebastian Reichel
2015-02-28 13:22 ` Alexandre Belloni
2015-02-28 16:12 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150228161215.GB886@earth \
--to=sre@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox